Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

RPC errors should not be ugly on the iroh CLI #139

Open
faassen opened this issue Oct 17, 2022 · 1 comment
Open

RPC errors should not be ugly on the iroh CLI #139

faassen opened this issue Oct 17, 2022 · 1 comment

Comments

@faassen
Copy link
Contributor

faassen commented Oct 17, 2022

Ugly is defined as:

  • A nice enough looking Error: foo where the text foo is incomprehensible/plain wrong

  • An ugly looking programmer-style output.

  • A crash

The List

Connection problems ugly output:

Error: status: Unavailable, message: "error trying to connect: tcp connect error: Connection refused (os error 111)", details: [], metadata: MetadataMap { headers: {} }

Caused by:
    0: transport error
    1: error trying to connect: tcp connect error: Connection refused (os error 111)
    2: tcp connect error: Connection refused (os error 111)
    3: Connection refused (os error 111)
@b5
Copy link
Member

b5 commented Nov 2, 2022

part of the issue surrounds RPC error handling, which is nontrivial. Errors should be better with the switch to tarpc (see #95).

Let's repurpose this issue to be specifically about errors stemming from RPC connections, and making them not gross

@b5 b5 changed the title ugly iroh CLI error messages RPC errors should not be ugly on the iroh CLI Nov 2, 2022
@dignifiedquire dignifiedquire transferred this issue from n0-computer/iroh Feb 17, 2023
@ramfox ramfox removed this from iroh Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants