fix: check and watch should display the same service names
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds more formalization to the different service names. We can now expect that the `SERVICE_NAME`s (aka the name that `tonic_health` assigns each service) is the string on which we need to fetch the health status from `tonic_health`, and nothing more. Once we start turning those responses into `StatusRow`s and `StatusTable`s, we can expect only display names to exist.
dignifiedquire
approved these changes
May 31, 2022
dignifiedquire
pushed a commit
that referenced
this pull request
Feb 20, 2023
Enforce debug instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more formalization to the different service names. We can now
expect that the
SERVICE_NAMEs (aka the name thattonic_healthassigns each service) is the string on which we need to fetch the
health status from
tonic_health, and nothing more.Once we start turning those responses into
StatusRows andStatusTables, we can expect only display names to exist.closes n0-computer/beetle#260