Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: p2p api service calls with a p2p-specific error, better feedback #402

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

b5
Copy link
Member

@b5 b5 commented Oct 23, 2022

Work into handling errors related to services that are down. p2p subsytem gets it's own specific error feedback + hint, and clean up the boilerplate error for connection refusal cases we don't specifically handle:

Screen Shot 2022-10-23 at 12 28 37 PM

related to n0-computer/beetle#120

@b5 b5 added the c-ctl label Oct 23, 2022
@b5 b5 added this to the v0.1.0 milestone Oct 23, 2022
@b5 b5 self-assigned this Oct 23, 2022
@b5 b5 requested a review from dignifiedquire October 23, 2022 16:32
@b5 b5 requested review from rklaehn and ramfox October 24, 2022 10:44
@b5 b5 merged commit b565231 into main Oct 24, 2022
@ramfox ramfox deleted the b5/no_p2p_subcommand_without_service branch October 24, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants