feat(ci): improve protoc install & add code coverage checks #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
force-pushed
the
arqu/ci_playground
branch
6 times, most recently
from
6f488de to
967deb8
Compare
Arqu
force-pushed
the
arqu/ci_playground
branch
from
967deb8 to
e4094f5
Compare
Codecov Report
@@ Coverage Diff @@
## main #538 +/- ##
=======================================
Coverage ? 74.72%
=======================================
Files ? 153
Lines ? 22497
Branches ? 0
=======================================
Hits ? 16811
Misses ? 5686
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Arqu
force-pushed
the
arqu/ci_playground
branch
from
9ab0acf to
271dbd4
Compare
Arqu
changed the title
Arqu
requested review from
b5,
dignifiedquire and
flub
and removed request for
b5
b5
previously approved these changes
Nov 23, 2022
.github/workflows/ci.yml
Outdated
Comment on lines
316
to
320
| # iroh-util/src/lock.rs#test_locks uses a fork() command & fails only in | ||
| # GHA if this is not present | ||
| # https://twitter.com/steipete/status/921066430220652544?lang=en | ||
| # https://blog.phusion.nl/2017/10/13/why-ruby-app-servers-break-on-macos-high-sierra-and-what-can-be-done-about-it/ | ||
| OBJC_DISABLE_INITIALIZE_FORK_SAFETY: "YES" |
There was a problem hiding this comment.
Have we run without this on our new runners to see if macOS still chokes?
| @@ -10,4 +10,5 @@ anyhow = "1" | |||
| clap = { version = "4.0.9", features = ["derive"] } | |||
| clap_mangen = "0.2.2" | |||
| dirs-next = "2.0.0" | |||
| xtaskops = "0.2.2" | |||
|
Can we add the codecov configuration file that turns off the report-comment-on-PR thingie? It's super irritating |
flub
previously approved these changes
Nov 24, 2022
Arqu
force-pushed
the
arqu/ci_playground
branch
from
271dbd4 to
c625b6e
Compare
Arqu
force-pushed
the
arqu/ci_playground
branch
from
e4c0480 to
269a8c6
Compare
flub
approved these changes
Nov 24, 2022
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Nov 24, 2022
…ter#538) * fix(ci): make protoc install more reliable * ops(ci): coverage * refactor(ci): cleanup CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.