This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
gateway & p2p improvements #264
Comments
Given that our blocks are limited at 2MiB, and that neither our DB nor the rpc layer are currently streaming them, I am not sure this is actually worth the work currently. |
dignifiedquire
referenced
this issue
in n0-computer/iroh
May 24, 2022
dignifiedquire
referenced
this issue
in n0-computer/iroh
May 24, 2022
Agree, this was more a "we should do it eventually thing" |
dignifiedquire
referenced
this issue
in n0-computer/iroh
May 24, 2022
dignifiedquire
referenced
this issue
in n0-computer/iroh
May 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently many requests go and invoke
fetch_bitswap
with an empty provider list (ref trace ID2b90b66cb34b936f005cde120d35de0e
). We should fail fast here and return 404 or something similar.The response from the resolver on gateway should be a stream, both to avoid loading everything into memory and significantly reduce the time to first byte which is currently
t(fetch_bitswap) + some_overhead
while it could bet(fetch_bitswap_first_byte) + some_overhead
. This also allows us to return metrics like time to first byte/block, latency vs time etc.The text was updated successfully, but these errors were encountered: