fix(editor): Fix custom API call notice #10227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
requested changes
Jul 29, 2024
| @@ -97,11 +97,13 @@ export function useNodeHelpers() { | |||
|
|
|||
| if (!isObject(parameters)) return false; | |||
|
|
|||
| if ('resource' in parameters && 'operation' in parameters) { | |||
| if ('resource' in parameters || 'operation' in parameters) { | |||
There was a problem hiding this comment.
since isCustomApiCallSelected is exported, and since this composable has a test file already, can we please add a test for isCustomApiCallSelected to prevent this from happening again 🙏🏽
There was a problem hiding this comment.
Maybe @elsmr can pitch in :)
Else I'll come to this later
ivov
changed the title
n8n-assistant
bot
added
n8n team
|
I'll ask @cstuncsik for help tomorrow. FE tests always a struggle :/ |
valya
approved these changes
Jul 30, 2024
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
netroy
approved these changes
Jul 30, 2024
|
✅ All Cypress E2E specs passed |
|
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://n8nio.slack.com/archives/C03594NKD7W/p1722239661807279
Broken here: https://github.com/n8n-io/n8n/pull/9583/files#diff-1003644eef3a21ff17fff2852d58d9c4372a0a38e03a7916aea75c3735bf76e4R80-R87