feat(core): Allow filtering workflows by project and transferring workflows in Public API #10231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
valya
suggested changes
Jul 30, 2024
| if ((projectId && !role) || (!projectId && role)) { | ||
| return res.status(400).json({ | ||
| message: | ||
| 'When creating a workflow and specifying s project, please specify both projectId and role', |
There was a problem hiding this comment.
Suggested change
| 'When creating a workflow and specifying s project, please specify both projectId and role', | |
| 'When creating a workflow and specifying a project, please specify both projectId and role', |
Comment on lines
214
to
220
| const { projectId, role, ...rest } = req.body; | ||
|
|
||
| if ((projectId && !role) || (!projectId && role)) { | ||
| return res.status(400).json({ | ||
| message: "When updating a workflow's project, please specify both projectId and role", | ||
| }); | ||
| } |
There was a problem hiding this comment.
Transferring workflows should probably be it's own endpoint
Comment on lines
104
to
107
| return await Db.transaction(async (tx) => { | ||
| await tx.update(WorkflowEntity, workflowId, updateData); | ||
| await tx.update(SharedWorkflow, { workflowId }, { projectId, role }); | ||
| }); |
There was a problem hiding this comment.
Should probably call EnterpriseWorkflowService.transferOne, since more things need done to transfer a workflow
Comment on lines
62
to
73
| const projectRepository = Container.get(ProjectRepository); | ||
|
|
||
| const project = projectId | ||
| ? await projectRepository.getProjectForUserOrFail(projectId, userId) | ||
| : await projectRepository.getPersonalProjectForUserOrFail(userId); | ||
|
|
||
| const createdWorkflow = await createWorkflow( | ||
| workflow, | ||
| req.user, | ||
| project, | ||
| role ?? 'workflow:owner', | ||
| ); |
There was a problem hiding this comment.
We need to check the user's scopes on the project for workflow:create first
ivov
changed the title
valya
approved these changes
Jul 30, 2024
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
ivov
deleted the
pay-1788-add-project-related-params-to-public-api-workflows-endpoints
branch
cstuncsik
pushed a commit
that referenced
this pull request
Jul 31, 2024
…kflows in Public API (#10231)
Merged
|
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2024
…kflows in Public API (#10231)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/PAY-1788