Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with gmail and http request nodes in version 0.139.1. #2256

Closed
Yaccobv2 opened this issue Sep 28, 2021 · 6 comments
Closed

Problem with gmail and http request nodes in version 0.139.1. #2256

Yaccobv2 opened this issue Sep 28, 2021 · 6 comments
Assignees

Comments

@Yaccobv2
Copy link

Yaccobv2 commented Sep 28, 2021

Hi! There is a problem with gmail node and http request node in version 0.139.1. After I restored n8n to version 0.138.0 everything works perfectly fine.

Gmail node does not apply selected tags and queries correctly, for example node reads emials without "UNREAD" tags or emails that doesn't contain query text "test emails". Also the last item returned by this node is undefined and it repeats itself every time I run the workflow.
Configuration:

 {
    "parameters": {
      "resource": "message",
      "operation": "getAll",
      "returnAll": true,
      "additionalFields": {
        "format": "resolved",
        "labelIds": [
          "Label_6577020579567117534",
          "UNREAD"
        ],
        "q": "={{$json[\"0\"][\"Subject\"]}}"
      }
    },
    "name": "Get Messages",
    "type": "n8n-nodes-base.gmail",
    "typeVersion": 1,
    "position": [
      590,
      -40
    ],
    "credentials": {
      "gmailOAuth2": "integromat"
    }
  },

Http request doesn't send binary files and results with error:
"Converting circular structure to JSON --> starting at object with constructor TLSSocket | property _httpMessage -> object with constructor ClientRequest --- property socket closes the circle"

Configuration:

  {
    "parameters": {
      "requestMethod": "POST",
      "url": "=https://api.trello.com/1/cards/{{$node[\"Trello\"].json[\"id\"]}}/attachments?key=***&token=***",
      "allowUnauthorizedCerts": true,
      "jsonParameters": true,
      "options": {
        "bodyContentType": "multipart-form-data",
        "fullResponse": true
      },
      "sendBinaryData": true,
      "binaryPropertyName": "=data"
    },
    "name": "TRELLO ADD ATTACHMENT",
    "type": "n8n-nodes-base.httpRequest",
    "typeVersion": 1,
    "position": [
      2180,
      270
    ],
    "continueOnFail": true
  },

Hope you are able to solve this issue or guide me how should I resolve it in my workflow :) (CC @dolohow)

@janober
Copy link
Member

janober commented Sep 30, 2021

Please try again with the just released [email protected]

It contains multiple fixes

@todaysday
Copy link

On [email protected] and [email protected] same problem with Gmail node.
It ignores any Label IDs matching and shows everything in the mailbox

@janober
Copy link
Member

janober commented Oct 5, 2021

Thanks for confirming. Did assing to @krynble he will have a look.

@krynble
Copy link
Contributor

krynble commented Oct 6, 2021

Hello @Yaccobv2

Thanks for your report. I was able to reproduce and fix the Gmail issue. You can find the PR #2289. Should be released soon.

On a side node, I tested the HTTP Request issue you mentioned and was unable to simulate. One thing to node is that the Binary property name is set to an expression. Probably not the issue, but this is something I noticed.

I have created a sample node that you can use here:

{
  "nodes": [
    {
      "parameters": {
        "requestMethod": "POST",
        "url": "https://krynble.free.beeceptor.com/upload",
        "allowUnauthorizedCerts": true,
        "jsonParameters": true,
        "options": {
          "bodyContentType": "multipart-form-data",
          "fullResponse": true
        },
        "sendBinaryData": true
      },
      "name": "HTTP Request",
      "type": "n8n-nodes-base.httpRequest",
      "typeVersion": 1,
      "position": [
        650,
        300
      ]
    }
  ],
  "connections": {}
}

@janober
Copy link
Member

janober commented Oct 6, 2021

As @krynble mentioned did the issue get fixed and is now also merged. Will be released with the next version.

@janober janober closed this as completed Oct 6, 2021
@janober
Copy link
Member

janober commented Oct 7, 2021

Fix got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants