Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing subject_token without aud claim to be exchanged #13

Closed
tommytroen opened this issue Sep 29, 2020 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request investigation

Comments

@tommytroen
Copy link
Collaborator

When using access_token from IDPorten as subject_token we now get a JWT without aud claim, this fails when validated in tokendings. Consider allowing tokens without aud to be validated.

Investigate and discuss consequences before implementing.

@ybelMekk ybelMekk linked a pull request Dec 4, 2020 that will close this issue
@ybelMekk
Copy link
Contributor

ybelMekk commented Jan 5, 2021

  • Maskinporten as issuer do not provide sub and aud in JWT body, the external client must specify those claims explicitly.
  • Add ability to configure validation of claims for subject_token for each issuer.
  • This is to introduce more flexibility
  • To achieve the goal of a test rig for TokenX (including digdirator, jwker and digdir integration).

@ybelMekk ybelMekk self-assigned this Jan 5, 2021
@ybelMekk ybelMekk added the enhancement New feature or request label Jan 5, 2021
@ybelMekk
Copy link
Contributor

Finished?

@ybelMekk
Copy link
Contributor

Seems like this can be closed, the issue is take care of, and maskinporten exchange of token is another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants