Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with percentiles chart navigation #70

Closed
brenol opened this issue Oct 18, 2020 · 1 comment
Closed

fix issue with percentiles chart navigation #70

brenol opened this issue Oct 18, 2020 · 1 comment

Comments

@brenol
Copy link
Contributor

brenol commented Oct 18, 2020

OK, so this one is actually weird.

From the point of view of code, the current implementation is correct.

From the point of view of usability, though, it's incorrect.

As the first chart in ali is latencyChart, pressing L the first time does not change to the next chart, which is percentiles.
This problem does not happen with backwards button (H), and is easily fixed with changing start position to 0 (which is a fact).

I'm finishing a PR that will fix this problem.

@nakabonne
Copy link
Owner

resolved by #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants