Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BetterSongList in Namespace #1

Closed
kinsi55 opened this issue Apr 11, 2022 · 6 comments
Closed

BetterSongList in Namespace #1

kinsi55 opened this issue Apr 11, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@kinsi55
Copy link

kinsi55 commented Apr 11, 2022

Would you mind removing BetterSongList from the namespace of this sorter?

My concern is that whenever there happens to be an update which might break this sorter people could be mislead by the logged exceptions, thinking it is related to BetterSongList itself when it might just be the Sorter that broke.

An alternative I'd have in mind could be LastPlayedSort_for_BetterSongList

@nanikit
Copy link
Owner

nanikit commented Apr 11, 2022

That makes sense. Thank you for suggestion.

@nanikit
Copy link
Owner

nanikit commented Apr 13, 2022

I'm considering BetterSort.LastPlayed as a new name. Do you have any concern?

@kinsi55
Copy link
Author

kinsi55 commented Apr 13, 2022

Maybe BSLSorter?

@nanikit
Copy link
Owner

nanikit commented Apr 13, 2022

I want the assembly name is close in alphabetical order at least. I intended indication of dependency. If there's no critical issue for the current candidate (BetterSort.LastPlayed), I want to stick to this.

@kinsi55
Copy link
Author

kinsi55 commented Apr 13, 2022

I think bettersort is further away than bslsorter - I personally would rather connect the last one to being what it is than the first one, but at the end of the day it is ofc your decision - both options are generally fine

@nanikit
Copy link
Owner

nanikit commented Apr 15, 2022

Close by 587ed81.

@nanikit nanikit closed this as completed Apr 15, 2022
@nanikit nanikit added the enhancement New feature or request label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants