-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BetterSongList in Namespace #1
Comments
That makes sense. Thank you for suggestion. |
I'm considering |
Maybe BSLSorter? |
I want the assembly name is close in alphabetical order at least. I intended indication of dependency. If there's no critical issue for the current candidate (BetterSort.LastPlayed), I want to stick to this. |
I think bettersort is further away than bslsorter - I personally would rather connect the last one to being what it is than the first one, but at the end of the day it is ofc your decision - both options are generally fine |
Close by 587ed81. |
Would you mind removing BetterSongList from the namespace of this sorter?
My concern is that whenever there happens to be an update which might break this sorter people could be mislead by the logged exceptions, thinking it is related to BetterSongList itself when it might just be the Sorter that broke.
An alternative I'd have in mind could be LastPlayedSort_for_BetterSongList
The text was updated successfully, but these errors were encountered: