Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the minimum numpy required? #584

Closed
mhvk opened this issue Nov 26, 2019 · 3 comments
Closed

What is the minimum numpy required? #584

mhvk opened this issue Nov 26, 2019 · 3 comments

Comments

@mhvk
Copy link
Contributor

mhvk commented Nov 26, 2019

In testing in our scintillometry package, the runs with numpy at 1.14 stopped working with #549 by @aarchiba - I think this is not a problem and we needed to update our minimum version of numpy anyway, but I could't find what PINT's minimum numpy is (or, rather, IIRC, requirements.txt gives 1.11 or so and requirements_dev.txt doesn't list it).

@mhvk
Copy link
Contributor Author

mhvk commented Nov 27, 2019

Just to be a bit clearer: the use of np.nditer as a context manager is only possible since numpy >=1.15. That does seem a reasonable minimum version, but it would be good to be explicit about this (and have a travis run that tests with the minimum supported version!).

@paulray
Copy link
Member

paulray commented Mar 7, 2020

Anyone know how to make a travis run that sets all the packages at the minimum supported version?

@mhvk
Copy link
Contributor Author

mhvk commented Mar 8, 2020

@paulray - over at astropy, we've just switched over to setting up environments with tox (which I see PINT has started to use as well), and in tox.ini, there's:

https://github.com/astropy/astropy/blob/424b3fb21f8cdf61db7fccb16ceee4c8bc99a80e/tox.ini#L49-L53

which then gets used in .travis.yml as:

https://github.com/astropy/astropy/blob/424b3fb21f8cdf61db7fccb16ceee4c8bc99a80e/.travis.yml#L79-L88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants