You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To save others from making this mistake (as well as to save myself from re-making it in the future), we could:
raise an error
always raise a warning
Maybe just raising an error would be fine, I can't imagine a situation where you have an object which is either a narwhals dataframe or a native object and in both cases you pass it as-is to is_pandas_dataframe
The text was updated successfully, but these errors were encountered:
If someone has a
df: nw.DataFrame
and they dothen they almost certainly meant to call
Source: I made this mistake 😳
To save others from making this mistake (as well as to save myself from re-making it in the future), we could:
Maybe just raising an error would be fine, I can't imagine a situation where you have an object which is either a narwhals dataframe or a native object and in both cases you pass it as-is to
is_pandas_dataframe
The text was updated successfully, but these errors were encountered: