Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check value for rate_duration in CALET notices #34

Open
lpsinger opened this issue Aug 7, 2024 · 11 comments
Open

Check value for rate_duration in CALET notices #34

lpsinger opened this issue Aug 7, 2024 · 11 comments
Assignees

Comments

@lpsinger
Copy link
Member

lpsinger commented Aug 7, 2024

          The reason I chose bkg_dur1 is that the documentation defines it as "the amount of time (units centi-sec) used to determine the background countrate when used for the lc_significance" and the descriptions for rate_duration is "Interval over rate signal to noise ratio calculation". Although thinking about it again I believe bkg_dur1 is being used to calculate the noise, so should I switch to fore_dur?

Originally posted by @athish-thiru in #20 (comment)

@athish-thiru
Copy link
Contributor

According to the source code, foreground duration (triggering interval) is the binning interval and I can't find any keyword in the the core schema that is equivalent to this, so I'm thinking of saving this value as trigger_duration. I can submit a new pull request for this.

@athish-thiru
Copy link
Contributor

Additionally, according to the source code, the url is a fake value to be used as a placeholder until a server is set up by the mission (this may be separate Issue).

@lpsinger
Copy link
Member Author

Additionally, according to the source code, the url is a fake value to be used as a placeholder until a server is set up by the mission (this may be separate Issue).

@jracusin, @Vidushi-GitHub, hopefully CALET has set up a real URL by now. Can you ping them?

@lpsinger
Copy link
Member Author

According to the source code, foreground duration (triggering interval) is the binning interval and I can't find any keyword in the the core schema that is equivalent to this, so I'm thinking of saving this value as trigger_duration. I can submit a new pull request for this.

That's not a trigger duration. @Vidushi-GitHub, would you please work up a PR to add an appropriate field to a core schema?

@Vidushi-GitHub
Copy link
Member

Additionally, according to the source code, the url is a fake value to be used as a placeholder until a server is set up by the mission (this may be separate Issue).

@jracusin, @Vidushi-GitHub, hopefully CALET has set up a real URL by now. Can you ping them?

I am not sure if other instruments are reporting this specific "fore_duration" (described in https://gcn.gsfc.nasa.gov/sock_pkt_def_doc.html), 4 foreground/triggering intervals 0.25s, 0.5s, 1s and 4s. Right now we should go with a specific field, and add it to the core if it's found in more instruments.

@lpsinger
Copy link
Member Author

@Vidushi-GitHub, do I understand that your proposed resolution is to leave this field as it is now?

@athish-thiru
Copy link
Contributor

Well right now that field is stored as 'rate_duration' which is defined in the core schema but does not accurately represent the value stored in this field. I could change this to 'foreground_duration' i.e. the same term used in the source code.

@Vidushi-GitHub
Copy link
Member

@Vidushi-GitHub, do I understand that your proposed resolution is to leave this field as it is now?

Yes correct! It's not conventional way in other gamma-ray instruments. We will add in core schema if we find more such missions using this field.

@Vidushi-GitHub
Copy link
Member

Additionally, according to the source code, the url is a fake value to be used as a placeholder until a server is set up by the mission (this may be separate Issue).

@jracusin, @Vidushi-GitHub, hopefully CALET has set up a real URL by now. Can you ping them?

@jracusin shall we ping the CALET team, if they have real URLs for the light curve?

@athish-thiru
Copy link
Contributor

athish-thiru commented Sep 3, 2024

I found this link (It seems to be the webpage for one of the PIs of the mission?) for the CALET mission that does seem to have some of the light curves for the initial notices but they seem to have stop updating it after 2019. Similarly I found that some of the initial notices on the gcn archive have a functioning lightcurve url but stop being updated around the same time.

@lpsinger
Copy link
Member Author

lpsinger commented Sep 4, 2024

@Vidushi-GitHub, @athish-thiru, please contact the CALET team to check for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants