Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE_PSP_TIMER_LOW32_ROLLOVER defined but not used in vxworks timebase implementation #348

Open
skliper opened this issue Jun 9, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@skliper
Copy link
Contributor

skliper commented Jun 9, 2022

Is your feature request related to a problem? Please describe.
Defined here:

/**
* \brief The number that the least significant 32 bits of the 64 bit
* time stamp returned by CFE_PSP_Get_Timebase rolls over. If the lower 32
* bits rolls at 1 second, then the CFE_PSP_TIMER_LOW32_ROLLOVER will be 1000000.
* if the lower 32 bits rolls at its maximum value (2^32) then
* CFE_PSP_TIMER_LOW32_ROLLOVER will be 0.
*/
#define CFE_PSP_TIMER_LOW32_ROLLOVER 0

Expected use here:

/******************************************************************************
** Function: CFE_PSP_GetTimerLow32Rollover()
**
** Purpose:
** Provides the number that the least significant 32 bits of the 64 bit
** time stamp returned by CFE_PSP_Get_Timebase rolls over. If the lower 32
** bits rolls at 1 second, then the CFE_PSP_TIMER_LOW32_ROLLOVER will be 1000000.
** if the lower 32 bits rolls at its maximum value (2^32) then
** CFE_PSP_TIMER_LOW32_ROLLOVER will be 0.
**
** Arguments:
**
** Return:
** The number that the least significant 32 bits of the 64 bit time stamp
** returned by CFE_PSP_Get_Timebase rolls over.
*/
uint32 CFE_PSP_GetTimerLow32Rollover(void)
{
return 0;
}

Describe the solution you'd like
Use the define or delete it. Note it's defined as 0 and the function returns 0 so behavior wouldn't change.

Describe alternatives you've considered
None.

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

Ping @superolmo

@skliper skliper added the enhancement New feature or request label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant