Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reentrant version of decompress routine in CFE FS #36

Closed
skliper opened this issue Sep 30, 2019 · 8 comments
Closed

Reentrant version of decompress routine in CFE FS #36

skliper opened this issue Sep 30, 2019 · 8 comments
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

The FS application has a feature where it can decompress file content on the fly. However the decompression routine keeps its internal state in global variables which makes it non-reentrant. To protect against concurrent usage a mutex is used but this has a major performance impact.

The global variables should be replaced with a state structure so that it can be multithreaded like all other parts of CFS.

For the time being a global state object can be implemented in order to preserve API compatibility.

@skliper skliper added this to the 6.5.0 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 5. Created by jphickey on 2014-12-24T08:46:04, last modified: 2019-03-05T14:57:55

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2014-12-24 10:29:36:

Pushed [changeset:65a79276] to address this.

Branch name is trac-5-cfe_fs_decompress_reentrant

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-04-06 11:21:58:

This is ready for review/merge

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by acudmore on 2015-04-06 14:01:05:

Recommend accept

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-04-07 12:45:58:

Tested changeset [changeset:65a7927] as part of the ic-2015-03-10 merge.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-04-13 15:15:34:

Part of integration candidate 2015-03-10,
committed to cFS CFE Development branch on 2015-04-10
as part of merge [changeset:7d6f6d0].

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2016-02-16 13:16:45:

Susie confirmed these tickets have been approved for CFE 6.5

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-03-05 14:57:55:

Milestone renamed

@skliper skliper closed this as completed Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant