Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE enumeration names #42

Closed
skliper opened this issue Sep 30, 2019 · 11 comments
Closed

CFE enumeration names #42

skliper opened this issue Sep 30, 2019 · 11 comments
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

In order to reduce the chance of name space conflicts, enumerated names should follow the general form, with the value prefixed by the group name and the app name:

<VALUEID_1>
<VALUEID_2>
....
<VALUEID_N>

This ensures that even if two enums use the same value name(s) they will not conflict with each other.

Most #define'd values already follow this general form, but there are some exceptions. These should be fixed to be consistent.

@skliper skliper added this to the 6.5.0 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 11. Created by jphickey on 2014-12-30T21:09:22, last modified: 2019-03-05T14:57:55

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-01-26 13:19:52:

Branch "trac-11-cfe_es_enum_names" addresses this

Commit [changeset:380cd96]

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-03-13 16:08:43:

DEPENDENCY NOTE: This change depends on some PSP macro names that are added as part of PSP ticket 6:

[https://babelfish.arc.nasa.gov/trac/cfs_psp/ticket/6]

Any build integrating this fix must also have the corresponding change set in the PSP.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-04-06 11:39:08:

This is ready for review/merge

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by sstrege on 2015-04-06 14:35:09:

Concur with changes/merge

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by acudmore on 2015-04-06 14:56:38:

Recommend accept.

I wondered why the reset types and subtypes were moved to the PSP, but I understand after reading the PSP ticket. It makes sense to reduce the cFE dependency on the PSP.
In the future, it would be nice if we could figure out platform specific reset types. Not sure how the cFE would handle them, but getting the definitions in the PSP is a good first step.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jwilmot on 2015-04-07 08:55:37:

Concur.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-04-07 12:51:52:

Tested changeset [changeset:380cd96] as part of the ic-2015-03-10 merge.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-04-13 15:21:17:

Part of integration candidate 2015-03-10,
committed to cFS CFE Development branch on 2015-04-10
as part of merge [changeset:7d6f6d0].

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2016-02-25 10:17:32:

these will be fixed in CFE 6.5

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-03-05 14:57:55:

Milestone renamed

@skliper skliper closed this as completed Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant