-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error constants defined in "cfe_error.h" incorrectly use the "L" suffix #53
Comments
Imported from trac issue 22. Created by jphickey on 2015-01-16T15:28:37, last modified: 2019-03-05T14:57:55 |
Trac comment by jphickey on 2015-01-26 14:11:48: Pushed commit [changeset:96925ec0], branch name "trac-22-error_constants_as_int32" This removes all the "L" suffixes and uses the OSAL-defined "int32" type instead. This does not change semantics and works on both 32 and 64 bit machines. |
Trac comment by glimes on 2015-02-11 11:59:27: See [changeset:01adb82] |
Trac comment by jphickey on 2015-04-06 11:33:34: This is ready for review/merge |
Trac comment by sstrege on 2015-04-06 14:20:35: Concur with change/merge |
Trac comment by acudmore on 2015-04-07 09:34:29: Concur |
Trac comment by glimes on 2015-04-07 12:59:05: Tested changeset [changeset:01adb82] as part of the ic-2015-03-10 merge. |
Trac comment by glimes on 2015-04-13 15:11:43: Part of integration candidate 2015-03-10, |
Trac comment by glimes on 2016-02-25 10:17:32: these will be fixed in CFE 6.5 |
Trac comment by jhageman on 2019-03-05 14:57:55: Milestone renamed |
The "L" suffix on an integer literal tells the compiler that it is supposed to be interpreted as a "long" type. However, CFE error constants are supposed to be 32-bit signed integers, which may or may not be the same thing as the system native "long" type.
To be correct, the constants should be defined to be the same as the "int32" OSAL type and the "L" suffix should be removed.
This causes problems on a 64-bit machine where the "long" type is 64 bits.
The text was updated successfully, but these errors were encountered: