Fix type mismatches and remove unnecessary typecasting

[skliper]

This ticket is to fix up areas of the code that have type mismatches or other unnecessary typecasting.

• In some areas, the standard "int" type is used when it should be the OSAL int32/uint32 type.
• In other areas, values are cast to certain types when it is not necessary to do so because the compiler will automatically do the right thing.

In the latter case, the type cast should be removed, because in certain situations it can actually interfere with the compiler doing the right thing and make it do the //wrong// thing instead. An example of this is casting to "int" with operands that are actually unsigned types and/or different widths. In the case that the forced "int" is a negative value, a sign extension might be performed and this might produce an unexpected result. In general, a cast should only be used when there is a good reason why the compiler's default conversion rules are not sufficient.

[skliper]

Imported from trac issue 26. Created by jphickey on 2015-01-21T13:46:44, last modified: 2019-03-05T14:57:55

[skliper]

Trac comment by jphickey on 2015-01-21 14:02:43:

For a specific example of how extra typecasting can actually //break// things, consider the following code:

{{{
unsigned long result1, result2;
unsigned int input = 0xDEADBEEFU;

result1 = input;
result2 = (int) input;

printf("Input = %u, Results = %ld %ld\n", input, result1, result2);
}}}

Compiling and executing this produces the following result:
{{{
Input = 3735928559, Results = 3735928559 -559038737
}}}

The first result (without any extra cast) is more likely the desired result.

[skliper]

Trac comment by jphickey on 2015-01-26 15:04:17:

Branch "trac-26-type_fixes" pushed -- commit [changeset:45f45f4]

This grabs several low hanging fruits regarding signed/unsigned mismatches and unnecessary casts.

[skliper]

Trac comment by jphickey on 2015-04-06 11:31:33:

This is ready for review/merge

[skliper]

Trac comment by sstrege on 2015-04-06 13:57:15:

Concur with changes/merge

[skliper]

Trac comment by acudmore on 2015-04-07 09:41:45:

Concur.

[skliper]

Trac comment by jwilmot on 2015-04-07 12:53:30:

Concur. Why would we have signed task ids? Should we have a TaskID_t?

[skliper]

Trac comment by glimes on 2015-04-07 13:01:01:

Tested changeset [changeset:45f45f491] as part of the ic-2015-03-10 merge.

[skliper]

Trac comment by glimes on 2015-04-13 15:24:53:

Part of integration candidate 2015-03-10,
committed to cFS CFE Development branch on 2015-04-10
as part of merge [changeset:7d6f6d0].

[skliper]

Trac comment by glimes on 2016-02-25 10:17:32:

these will be fixed in CFE 6.5

[skliper]

Trac comment by jhageman on 2019-03-05 14:57:55:

Milestone renamed