Ensure that return codes from PSP functions are checked

[skliper]

In some circumstances the return code from PSP functions (e.g. CFE_PSP_GetResetArea) is either not checked or incorrectly checked.

Wherever the return code is checked, instead of specifically checking for an error code like so:
{{{
if (Status == CFE_PSP_ERROR)
{

}
}}}

The code should check for non-success instead:
{{{
if (Status != CFE_PSP_SUCCESS)
{

}
}}}

This will make it more future-proof to PSP implementations that might return more specific errors.

[skliper]

Imported from trac issue 29. Created by jphickey on 2015-01-22T12:40:14, last modified: 2019-03-05T14:57:55

[skliper]

Trac comment by jphickey on 2015-01-26 16:25:58:

Branch "trac-29-psp_retcodes" pushed -- commit [changeset:2fdeec90]

This ensures that the return codes of PSP functions are checked per the above description.

[skliper]

Trac comment by jphickey on 2015-04-06 11:31:07:

This is ready for review/merge

[skliper]

Trac comment by sstrege on 2015-04-06 13:07:56:

Concur with changes/merge

[skliper]

Trac comment by acudmore on 2015-04-07 12:40:40:

Concur

[skliper]

Trac comment by glimes on 2015-04-13 15:21:56:

Part of integration candidate 2015-03-10,
committed to cFS CFE Development branch on 2015-04-10
as part of merge [changeset:7d6f6d0].

[skliper]

Trac comment by glimes on 2016-02-25 10:17:32:

these will be fixed in CFE 6.5

[skliper]

Trac comment by jhageman on 2019-03-05 14:57:55:

Milestone renamed