Fix "no return" warning on CFE_SB_ReadQueue() function

[skliper]

This is not a "real" warning, but it is flagged by static code analysis in Eclipse that the CFE_SB_ReadQueue() function has no return statement. Although there is no real code path that will //not// get to a return statement, static code analysis does not see that.

A trivial fix to consolidate the scattered return's into a single return at the end will get rid of this warning and make the code more readable.

[skliper]

Imported from trac issue 33. Created by jphickey on 2015-01-26T10:57:10, last modified: 2019-03-05T14:57:55

[skliper]

Trac comment by jphickey on 2015-01-26 11:03:18:

Pushed branch "trac-33-readqueue_return" to address this.

Commit [changeset:bb342e8]

[skliper]

Trac comment by jphickey on 2015-04-06 11:22:45:

This is ready for review/merge

[skliper]

Trac comment by sstrege on 2015-04-06 12:32:38:

I concur with these changes

[skliper]

Trac comment by jwilmot on 2015-04-06 15:13:48:

Concur.

[skliper]

Trac comment by acudmore on 2015-04-07 12:49:47:

Concur

[skliper]

Trac comment by glimes on 2015-04-07 13:14:09:

Tested changeset [changeset:bb342e8] as part of the ic-2015-03-10 merge.

[skliper]

Trac comment by glimes on 2015-04-13 15:16:14:

Part of integration candidate 2015-03-10,
committed to cFS CFE Development branch on 2015-04-10
as part of merge [changeset:7d6f6d0].

[skliper]

Trac comment by glimes on 2016-02-25 10:17:32:

these will be fixed in CFE 6.5

[skliper]

Trac comment by jhageman on 2019-03-05 14:57:55:

Milestone renamed