Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gauges do not handle missing objects #7908

Closed
akhenry opened this issue Oct 18, 2024 · 1 comment · Fixed by #7923
Closed

Gauges do not handle missing objects #7908

akhenry opened this issue Oct 18, 2024 · 1 comment · Fixed by #7923

Comments

@akhenry
Copy link
Contributor

akhenry commented Oct 18, 2024

Summary

A missing object in a Gauge will throw a JavaScript error in the console. The issue appears to be in this line of code, which assumes at least one range is returned -

this.valueKey = this.metadata.valuesForHints(['range'])[0].source;

Expected vs Current Behavior

There should not be any unhandled errors in the JavaScript console

@jvigliotta
Copy link
Contributor

jvigliotta commented Dec 4, 2024

Testing Instructions

  • Repro steps in VIPERGC-671
  • View a gauge with a missing object
  • Verify now errors in the console
  • Verify if you modify the start/end bounds/offsets that they are updated correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants