Add Fiber scheduler hooks for Kernel.sleep #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herwinw
force-pushed
the
fiber_scheduler_sleep
branch
from
d0d93c9 to
73784d4
Compare
Merged
herwinw
force-pushed
the
fiber_scheduler_sleep
branch
2 times, most recently
from
117b3d5 to
edef311
Compare
herwinw
force-pushed
the
fiber_scheduler_sleep
branch
from
a920899 to
af6f100
Compare
herwinw
force-pushed
the
fiber_scheduler_sleep
branch
from
af6f100 to
340b4c1
Compare
The test includes a very primitive Fiber scheduler. This one will probably be extended in future tests.
This pattern does not work as expected in Natalie, see natalie-lang#1337 for the bug report.
herwinw
force-pushed
the
fiber_scheduler_sleep
branch
2 times, most recently
from
cbe765f to
12f9897
Compare
It turns out our current code cannot use Fiber instances as hash keys.
herwinw
force-pushed
the
fiber_scheduler_sleep
branch
from
12f9897 to
e9b7b8a
Compare
This removes the need for some boilerplate whenever we need to run the scheduler.
|
This should do it. In hindsight I should have started with the limitless sleep, since most of the code is converting timestamps from and to various representations. |
|
So cool!!! 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be my work in progress for the coming time. I've gotten a very primitive (and incomplete) scheduler that switches Fibers in MRI. Next up is calling the scheduler from within Natalie, and we'll have our first actual checkbox for #1184.