Add String#byterindex #2193
Merged
Add String#byterindex #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might be as best we can do for now. In trying to get some of the regexp handling to work with offsets, I noticed chunks of code in CRuby's version of Onigmo that just don't exist in upstream. Without this code, the backward matching of regular expressions will not match CRuby. :-( Checkout `backward_search_range` if you want to revisit this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#217
Unfortunately there are some bits of the spec that we cannot pass with our current Onigmo library. I think we will need the patches that CRuby has for Onigmo that haven't been upstreamed.
I'm hesitant to vendor all the regex code from CRuby in our repository, as keeping it up-to-date would be a real pain. If we get ambitious someday, maybe we can try to upstream some of the Ruby changes to Onigmo... If that's even possible. I don't know if it's simply that no one has had time to upstream the changes, or if CRuby has a true fork of Onigmo at this point. 😬
In any case, I think this is good enough for now.