Fix Mutex#sleep race condition #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit more accurate.
The thread can report it is still running even though it will be sleeping very soon.
Mutex#sleep acts like an atomic Mutex#unlock + Thread#sleep. If some other thread sneaks in the middle of that and calls Thread#wakeup, the wakeup can be lost because we're not quite sleeping yet. `m_wakeup` is the "condition" for our std::condition_variable that allows us to check if we should immediately wake up.
seven1m
force-pushed
the
cond-var-sig-spec
branch
from
447ada5 to
e853dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutex#sleepacts like an atomicMutex#unlock+Thread#sleep.If some other thread sneaks in the middle of that and calls
Thread#wakeup, the wakeup can be lost because we're not quite sleeping yet.m_wakeupis the "condition" for ourstd::condition_variablethat allows us to check if we should immediately wake up.Fixes #2340 and #1966.