Change default build to release mode #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seven1m
force-pushed
the
default-release
branch
from
3178165 to
b217968
Compare
seven1m
force-pushed
the
default-release
branch
from
b217968 to
0ff4f00
Compare
Building in release mode slows down CI a lot on linux, up to two hours. While on macOS, we can finish in less than an hour. I want the benefit of running tests in release mode, but not to the point of taking two hours to run CI. So I'm compromising: release mode for the macos build; debug mode for the linux build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had some folks drop in and start benchmarking Natalie. It's counterintuitive that we would build in debug mode by default, so it's easy to miss. And now that I'm not chasing GC bugs regularly, I think it's time we switch the default build mode.
Of course, when debugging, we can easily
rake clean build_debugto get back the debug build.NOTE: This will slow down CI since compilation takes longer. Most of our time in CI is on compilation, since each script runs very quickly. I kept CI on Linux in debug mode because 2 hours just seemed like way too long to wait for a build. The macOS tests build in release mode and take around an hour.