Use Optional instead of nullptr for some method parameters #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is stop allowing Value to be nullptr. First we need to stop using nullptr as a default value for optional method args.
seven1m
force-pushed
the
less-null
branch
2 times, most recently
from
8874784 to
7adcdd5
Compare
No tests are failing, but I don't think we should set the m_klass of a new RegexpObject to nullptr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to eventually rid ourselves of
Values carrying anullptr.The first step, I figure, is to stop representing the absence of a method argument using
nullptr. I did a big chunk of the bindings here, changing them fromValuetoOptional<Value>.There is more work to do, but I'm tired. 😅