Clarify spec error for Regexp.last_match #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is not related to errors bubbling up, but simply because we
set our regexp globals as block local, which should be treated as scope
local.
A simple example:
```ruby
/foo/ =~ 'foobar'
-> { p Regexp.last_match }.call
```
This prints the MatchData object in MRI, but Natalie prints a nil.
We have the same issue the other way around:
```ruby
-> { /foo/ =~ 'foobar' }.call
p Regexp.last_match
```
Rewrite the failing specs into a form that works that is closer to the
original spec.
There is some logic conserning caller scopes and outer blocks in the
lookups, but that might have to be redone. This issue is not limited to
this spec, but it occurs everywhere we use any global references to
regex results.
seven1m
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is not related to errors bubbling up, but simply because we set our regexp globals as block local, which should be treated as scope local.
A simple example:
This prints the MatchData object in MRI, but Natalie prints a nil.
We have the same issue the other way around:
Rewrite the failing specs into a form that works that is closer to the original spec.
There is some logic conserning caller scopes and outer blocks in the lookups, but that might have to be redone. This issue is not limited to this spec, but it occurs everywhere we use any global references to regex results.