Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HQ doesn't use reprojected access vector #1615

Closed
emlys opened this issue Aug 15, 2024 · 0 comments · Fixed by #1637
Closed

HQ doesn't use reprojected access vector #1615

emlys opened this issue Aug 15, 2024 · 0 comments · Fixed by #1637
Assignees
Labels
bug Something isn't working good first issue Good for new members of the software team
Milestone

Comments

@emlys
Copy link
Member

emlys commented Aug 15, 2024

I noticed that in HQ, the input vector is reprojected, but the reprojected version is never used. The original version is used in the model:

LOGGER.debug("Reproject and rasterize Access vector")
reprojected_access_path = os.path.join(
intermediate_output_dir, 'access_projected_to_lulc_cur.gpkg')
reproject_access_task = task_graph.add_task(
func=pygeoprocessing.reproject_vector,
kwargs={
'base_vector_path': args['access_vector_path'],
'target_projection_wkt': lulc_wkt,
'target_path': reprojected_access_path,
'driver_name': 'GPKG'
},
target_path_list=[reprojected_access_path],
task_name='reproject_access_vector')
rasterize_access_task = task_graph.add_task(
func=pygeoprocessing.rasterize,
args=(args['access_vector_path'], access_raster_path),
kwargs={
'option_list': ['ATTRIBUTE=ACCESS'],
'burn_values': None
},
target_path_list=[access_raster_path],
dependent_task_list=[
create_access_raster_task, reproject_access_task],
task_name='rasterize_access')

If it does need to be reprojected, we should be using the reprojected version. If reprojection is unnecesssary, we can remove this step of the model.

@emlys emlys added bug Something isn't working good first issue Good for new members of the software team labels Aug 15, 2024
@dcdenu4 dcdenu4 added this to the 3.14.3 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for new members of the software team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants