Using client.smartCollectionSync defaults to wrong type declaration for detailedResult (always Falsy) vs using smartCollectionSync independently

[garshythoel]

For my code here:

const {
          created: createdObjects,
          updated: updatedObjects,
          deleted: deletedObjects
        } = (
          await client.smartCollectionSync({
            collection: {
              url: calendar.url,
              ctag: calendar.ctag,
              syncToken: calendar.syncToken,
              objects: localObjects.map(dbEventToDAVObject),
              objectMultiGet: client.calendarMultiGet
            },
            method: 'webdav',
            detailedResult: true
          })
        ).objects;

The TS typechecker throws error since it expects detailedResult to always be false (image below)

This also leads to the typechecker picking up the wrong overload for the function returns type and consequently errors on accessing created, updated and deleted

When i use smartCollectionSync directly (not from the clientMethod) - the overload for detailedResult: true is successfully picked up and no error

I also get the same issues using syncCalendars independently vs from the DAVClient method.

I can use the methods directly but since the examples in the documentation are all DAVClient based probably a good idea to fix the overloads

[natelindev]

will take a look this week.

[natelindev]

fixed in v2.1.1