Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spites by default - I just want inline SVGs #193

Closed
seansmyth opened this issue Jan 11, 2024 · 2 comments · Fixed by #200
Closed

Spites by default - I just want inline SVGs #193

seansmyth opened this issue Jan 11, 2024 · 2 comments · Fixed by #200

Comments

@seansmyth
Copy link

What version of astro-icon are you using?

^1.0.2

Astro Info

Not sure why, but I'm getting this error

Error: unknown command "info" for "astro"

I'm using Astro ^4.0.1" though.

If this issue only occurs in one browser, which browser is a problem?

All

Describe the Bug

Hi there,

I've used this library before and won't like using the SVG as spirtes option.

I want them to just be inline, just like what you have on your site.
https://www.astroicon.dev/

However, I don't see any mention of configuring this in the docs or googling.

Thanks

What's the expected result?

Link to Minimal Reproducible Example

https://astro.new/latest

@natemoo-re
Copy link
Owner

I can appreciate that! Would you mind explaining your use case or what problems sprites are causing? I'd appreciate more context so I can decide if sprites should remain the default in future versions.

I will definitely be exposing an option to inline SVGs in v1. Sorry for the inconvenience!

@seansmyth
Copy link
Author

Hi there,

Thanks for replying.

My use case is atypical, in fairness.

Working in a small agency, we build out 3/4 templates for a project. These are static HTML. We build the project and hand these compiled JS, HTML and CSS files over to the Backend team where they then integrate these templates into the CMS of their choosing.

So, in this case, we don't know if a spirite has been used on the page already or not.

Imagine a testimonial block that has large quote icon in the background.

A page that is created by the client when using the template we provide might use one or two of these. So we can't really know if the second one is to be a sprite.

In our use case, it'd be handiest to just have the SVG code output twice.

Hope that gives a bit of context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants