Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check bindings.rs into repository #1

Closed
stefnotch opened this issue Jan 3, 2025 · 0 comments · Fixed by #4
Closed

Check bindings.rs into repository #1

stefnotch opened this issue Jan 3, 2025 · 0 comments · Fixed by #4

Comments

@stefnotch
Copy link

I tried building Deno, which depends on this library denoland/deno#27535
At which point I ran into

error: failed to run custom build command for `libuv-sys-lite v1.48.2`

Caused by:
  process didn't exit successfully: `C:\Coding\GitHub\Tools\deno\target\debug\build\libuv-sys-lite-b69ec193f23d297d\build-script-build` (exit code: 101)
  --- stderr
  thread 'main' panicked at C:\Users\Stefnotch\.cargo\registry\src\index.crates.io-6f17d22bba15001f\bindgen-0.70.1\lib.rs:622:27:
  Unable to find libclang: "couldn't find any valid shared libraries matching: ['clang.dll', 'libclang.dll'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

From what I understand, this project depends on bindgen, which in turn depends on clang. Installing extra dependencies on Windows can be quite tricky.

I also noticed that napi-rs does not have a build.rs file, and instead has the generated bindings in the repository. Would it be reasonable for this project to do the same? If yes, I can try to provide a pull request.

System: Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant