Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ci-infra-service.yml work with multiple apps #647

Closed
lorenyu opened this issue Jun 20, 2024 · 2 comments · Fixed by #763
Closed

Make ci-infra-service.yml work with multiple apps #647

lorenyu opened this issue Jun 20, 2024 · 2 comments · Fixed by #763
Assignees
Labels
scope: ci/cd GitHub actions workflows workflow: good first issue Good for newcomers

Comments

@lorenyu
Copy link
Contributor

lorenyu commented Jun 20, 2024

infra/test/infra_test.go does not currently support multiple apps. It currently hardcodes app. to make it support multiple apps we will want to:

  1. separate the test into infra/test/<app_name>/infra_test.go
  2. extract the logic from .github/workflows/ci-infra-service.yml into a new callable workflow infra-test-app.yml (similar to deploy.yml and vulnerability-scans.yml)
  3. make .github/workflows/ci-infra-<app_name>.yml that calls the callable workflow
@lorenyu
Copy link
Contributor Author

lorenyu commented Jun 20, 2024

@rocketnova fyi since you're working on multi-app stuff. ci-infra-service.yml can probably be out of scope for your multi-app scripts since it needs to be refactored before it can be supported.

@lorenyu lorenyu added this to the Multiple applications milestone Jun 20, 2024
@lorenyu lorenyu added the scope: ci/cd GitHub actions workflows label Jun 20, 2024
@lorenyu lorenyu added the workflow: good first issue Good for newcomers label Jul 22, 2024
@lorenyu
Copy link
Contributor Author

lorenyu commented Jul 24, 2024

cc @doshitan you could theoretically work on this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: ci/cd GitHub actions workflows workflow: good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants