Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to install V 0.1.21 #8

Open
byteshiva opened this issue Oct 17, 2019 · 9 comments
Open

Not able to install V 0.1.21 #8

byteshiva opened this issue Oct 17, 2019 · 9 comments

Comments

@byteshiva
Copy link

byteshiva commented Oct 17, 2019

Steps to reproduce

asdf install v 0.1.21
==> Checking whether specified V release/reference exists...
==> Downloading 0.1.21 to /tmp/v_build_S9kr9w/v-version-0.1.21-src.tar.gz from https://github.com/vlang/v/archive/0.1.21.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   115    0   115    0     0    129      0 --:--:-- --:--:-- --:--:--   129
100 1444k    0 1444k    0     0  45631      0 --:--:--  0:00:32 --:--:-- 69319
==> Copying release into place
==> Checking whether specified release/reference containing v.c exists...
==> Downloading 0.1.21 to /tmp/v_build_S9kr9w/v-version-0.1.21-v.c from https://github.com/vlang/vc/archive/0.1.21.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   116    0   116    0     0     12      0 --:--:--  0:00:09 --:--:--    29
100    15  100    15    0     0      1      0  0:00:15  0:00:11  0:00:04    22

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

Expected behavior

vlang should have been installed
Actual behavior

vlang should have been installed from tar.gz file but it expects zip format for extraction and installation
Environment

OS: ubuntu

Linux 5.0.0-32-generic #34-Ubuntu

asdf version:

➜ asdf version
version: v0.7.4

@byteshiva
Copy link
Author

Reference : asdf-vm/asdf#580 (comment)

@byteshiva
Copy link
Author

Any update!!

@ndac-todoroki
Copy link
Owner

Thanks for the information!
I haven't been watching V's changelog for a while... I'll give a look and try to fix it.

@ndac-todoroki
Copy link
Owner

ndac-todoroki commented Jan 27, 2020

Sorry for taking this over the holidays;;

I've made a little fix for this.
The issue was: v.c no was no longer released with versioning.
It wasn't realistic to get the correct v.c commit hash from the asdf install info, so I chose to always use the latest v.c available.
This may make incompatibility for older versions of v, but should work for the latest version (at least?)

doing asdf plugin-update v should fix this issue!

@ndac-todoroki
Copy link
Owner

Now the fix fixes the not-installable problem, V doesn't self-recompile correctly currently. >> #9

@byteshiva
Copy link
Author

Thanks, @ndac-todoroki, Now it works.

Detailed log for reference.

➜ asdf plugin-update v 
Updating v...
remote: Enumerating objects: 11, done.
remote: Counting objects: 100% (11/11), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 8 (delta 4), reused 7 (delta 3), pack-reused 0
Unpacking objects: 100% (8/8), done.
From https://github.com/ndac-todoroki/asdf-v
   939b2e6..92fc386  master     -> master
   939b2e6..92fc386  master     -> origin/master
Already on 'master'
Your branch is up to date with 'origin/master'.
~ via ⬢ v13.5.0 via 🐍 v3.8.0 took 2s 
➜ asdf install v  0.1.24 
==> Checking whether specified V release/reference exists...
==> Downloading 0.1.24 to /tmp/v_build_GIEoEk/v-version-0.1.24-src.tar.gz from https://github.com/vlang/v/archive/0.1.24.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   115    0   115    0     0    287      0 --:--:-- --:--:-- --:--:--   286
100 3241k    0 3241k    0     0   779k      0 --:--:--  0:00:04 --:--:-- 1055k
==> Copying release into place
==> Looking for the latest v.c from https://github.com/vlang/vc...
==> Downloading master to /tmp/v_build_GIEoEk/v-version-0.1.24-v.c from https://github.com/vlang/vc/archive/master.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   116    0   116    0     0    218      0 --:--:-- --:--:-- --:--:--   218
100  414k    0  414k    0     0   308k      0 --:--:--  0:00:01 --:--:-- 1524k
==> Self-recompiling V compiler
/home/xyz/.asdf/installs/v/0.1.24
~ via ⬢ v13.5.0 via 🐍 v3.8.0 took 8s 
➜ v --version 
V 0.1.24 78c96fe
~ via ⬢ v13.5.0 via 🐍 v3.8.0 
➜ 


@ndac-todoroki
Copy link
Owner

ndac-todoroki commented Jan 28, 2020

hey @byteshiva ,

Thanks for your verify! Can you tell me what OS/Environment are you on? (You were on Ubuntu...)
Can you execute v? (not v --version, but the REPL one v)

@byteshiva
Copy link
Author

byteshiva commented Jan 28, 2020

➜ uname -a 
Linux  5.3.0-29-generic #31-Ubuntu SMP x86_64 x86_64 x86_64 GNU/Linux/ 

No, I'm unable to enter into repl session using v repl

Error State

➜ v repl 
V panic: V tool "/home/xyz/.asdf/installs/v/0.1.24/tools/vrepl.v" could not be compiled
V error: import cycle detected between the following modules: 

 * os -> filepath
 * filepath -> os
                                               | 0x56388d6850cd | /home/xyz/.asdf/installs/v/0.1.24/bin/v(+0x40cd) 
                                               | 0x56388d71a6de | /home/xyz/.asdf/installs/v/0.1.24/bin/v(+0x996de) 
                                               | 0x56388d71aa29 | /home/xyz/.asdf/installs/v/0.1.24/bin/v(+0x99a29) 
                                               | 0x56388d71d723 | /home/xyz/.asdf/installs/v/0.1.24/bin/v(+0x9c723) 
                                               | 0x7f9e7f1a61e3 | /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) 
                                               | 0x56388d68392e | /home/xyz/.asdf/installs/v/0.1.24/bin/v(+0x292e) 
/ 

@ndac-todoroki
Copy link
Owner

thanks @byteshiva !
I wanted to be sure about that. I've realized this issue after this fix. Sorry about it. The new issue is now described as #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants