Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error message for incorrect dependency #29

Closed
austinabell opened this issue Aug 18, 2022 · 1 comment · Fixed by #49
Closed

Bad error message for incorrect dependency #29

austinabell opened this issue Aug 18, 2022 · 1 comment · Fixed by #49
Assignees

Comments

@austinabell
Copy link
Contributor

austinabell commented Aug 18, 2022

The error message, if someone has the near-sdk dependency as anything like near-sdk = "4.0.0" or near-sdk = "4.1.0-pre.1, the error message is:

ERROR: near-sdk dependency should be a table

Which is very unhelpful and does not indicate why this is failing. Ideally, for previous versions it should indicate what the minimum SDK version supported is, and for ones that don't apply the abi feature, it should either indicate that it is required or be able to add that feature automatically.

cc @shelegdmitriy

@austinabell
Copy link
Contributor Author

austinabell commented Aug 29, 2022

Adding this as another error message that is bad:

the package `non-fungible-token` depends on `near-sdk`, with features: `__abi-generate` but `near-sdk` does not have these features.

This depends on near/near-sdk-rs#893 (which hasn't currently been merged or released) which will be unusable unless you know that.

cc @miraclx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants