Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create comment on PR on after each eas update #682

Closed
confraria opened this issue Sep 13, 2022 · 6 comments · Fixed by #921
Closed

Create comment on PR on after each eas update #682

confraria opened this issue Sep 13, 2022 · 6 comments · Fixed by #921
Assignees

Comments

@confraria
Copy link
Contributor

confraria commented Sep 13, 2022

UPDATE 15/09/2022: we decided that the outcome of this activity is a contribution to the expo.github-action repo to make the preview comment action work with eas

eas update replaces expo publish which posted a comment to the PR with a QR code and a link to start the app from Expo Go.

Right now the action doesn't support this feature yet. This problem is tracked in the following issue:
expo/expo-github-action#189

@simoneb
Copy link
Member

simoneb commented Sep 15, 2022

@confraria would it be worth contributing this feature to the expo action itself?

@confraria
Copy link
Contributor Author

I think so. from the comments (and even some discord messages) I believe it would be useful to plenty of people.

@simoneb
Copy link
Member

simoneb commented Sep 15, 2022

Ok cool, let's turn this activity into a contribution to that repo then

@SirCQQ SirCQQ self-assigned this Sep 22, 2022
@brunopascottini brunopascottini self-assigned this Nov 22, 2022
@brunopascottini
Copy link
Contributor

brunopascottini commented Nov 22, 2022

@SirCQQ has submitted a PR for this issue but it was not merged yet. I messaged the people responsible for doing so. I'll keep track of that

@Mazuh
Copy link
Contributor

Mazuh commented Jan 3, 2023

the work is scattered on several PRs/repos (nobody has permission to actively collaborate in a more straightforward way), but here is the most updated PR: expo/expo-github-action#200

@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.1 🎉

The release is available on:

Your optic bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants