Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Pipe buffer deadlock #2928

Open
Adam-D-Lewis opened this issue Jan 29, 2025 · 1 comment · May be fixed by #2929
Open

[BUG] - Pipe buffer deadlock #2928

Adam-D-Lewis opened this issue Jan 29, 2025 · 1 comment · May be fixed by #2929
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@Adam-D-Lewis
Copy link
Member

Describe the bug

I've seen an issue where there is deadlock shortly after running a nebari deploy command. The deadlock occurs when reading in the state from the tofu show command. The issue is a pipe buffer deadlock.

See the warning in the python docs:

Warning Use communicate() rather than .stdin.write, .stdout.read or .stderr.read to avoid deadlocks due to any of the other OS pipe buffers filling up and blocking the child process.

We don't want to use communicate in this case b/c it blocks and we would only display output to our users after terraform stops running which could be very long in some cases.

Expected behavior

No deadlock

OS and architecture in which you are running Nebari

Linux

How to Reproduce the problem?

Working on it

Command output

Versions and dependencies used.

No response

Compute environment

None

Integrations

No response

Anything else?

No response

@Adam-D-Lewis Adam-D-Lewis added needs: triage 🚦 Someone needs to have a look at this issue and triage type: bug 🐛 Something isn't working labels Jan 29, 2025
@Adam-D-Lewis Adam-D-Lewis linked a pull request Jan 29, 2025 that will close this issue
10 tasks
@Adam-D-Lewis Adam-D-Lewis linked a pull request Jan 29, 2025 that will close this issue
10 tasks
@Adam-D-Lewis
Copy link
Member Author

I saw this issue when my nebari config had a long base64 encoded thumbnail for jhub apps in it which I believe explains the full buffer.

@Adam-D-Lewis Adam-D-Lewis self-assigned this Jan 29, 2025
@Adam-D-Lewis Adam-D-Lewis removed the needs: triage 🚦 Someone needs to have a look at this issue and triage label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: New 🚦
Development

Successfully merging a pull request may close this issue.

1 participant