Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend DB encryption at rest for possibly sensitive data #26

Open
naorlivne opened this issue Jan 22, 2019 · 0 comments
Open

Add backend DB encryption at rest for possibly sensitive data #26

naorlivne opened this issue Jan 22, 2019 · 0 comments

Comments

@naorlivne
Copy link
Member

naorlivne commented Jan 22, 2019

Expected/Wanted Behavior

Some fields of apps stored in the backend DB may potentially contain sensitive data, this fields are:

  • The values of the envvars as they might store passwords

For infosec reasons they are best stored in the backend DB in an encrypted format, this can be achieved by having a known encryption token configured with the same value on all managers as a required config param that serves as the encryption key to encrypt\decrypt those fields when stored in the backend DB.

https://github.com/pyca/cryptography should be used rather then pycrypto as pycrypto hasn't been updated in years.

if the encryption token paramter is not set then it should default to None\empty\etc and not encrypt the data on the backend DB, this will also allow backward compliance with existing versions.

Actual Behavior

Envvars data stored at the backend DB is plaintext (user pass & tokens are already hashed, not encrypted as this is a better way of storing them as they will never need to be decrypted).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant