Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom labels option to application configs #28

Open
naorlivne opened this issue Feb 11, 2019 · 0 comments
Open

Add custom labels option to application configs #28

naorlivne opened this issue Feb 11, 2019 · 0 comments
Labels
enhancement help wanted low priority

Comments

@naorlivne
Copy link
Member

naorlivne commented Feb 11, 2019 •
edited
Loading

Expected/Wanted Behavior

It should be possible to add custom labels on an app level to running containers in addition to the existing Nebula labels of:

  • "app_name"
  • "orchestrator"

The existing Nebula labels should not be possible to be overwritten as so there should be some failsafe check to prevent overwriting them.

This should be an optional dict in the app config which defaults to {} if not set and in which case only the existing Nebula labels should be added.

Actual Behavior

Currently only the default labels are added to running containers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naorlivne