Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to not automatically --rm docker images and auto pull on every nebula app change #24

Closed
naorlivne opened this issue Sep 26, 2017 · 2 comments

Comments

@naorlivne
Copy link
Member

not automatically removing images & repulling them might have some uses in cases where you want to reuse local based images, when this is added there should also be a way to force\order GC older images that are unused (one of the original reason why currently Nebula automatically deletes all images so aggressively) otherwise I can imagine IoT devices will get filled with old images quickly.

@naorlivne
Copy link
Member Author

the new /prune option added will provide option to clean unused images so all hat remains of this is to have an option not to set force_pull = False in the app config

@naorlivne
Copy link
Member Author

rethinking about it made me realize that having a no pull option might lead to risky usages (what if someone cleans some of the devices of images between run but not all of them? what if someone pushes a new version over the same tag?) and it is a lot safer to always repull images, seeing how if the image layer is already in the drive it doesn't really forces downloading all over it again the time it takes for the extra pull is already minimal and with the new /prune endpoint there shouldn't be much worries about disk space anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant