Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move automatic Docker imags build from Docker Hub to Travis-CI #39

Closed
naorlivne opened this issue Jan 17, 2019 · 1 comment
Closed

Move automatic Docker imags build from Docker Hub to Travis-CI #39

naorlivne opened this issue Jan 17, 2019 · 1 comment

Comments

@naorlivne
Copy link
Member

Expected/Wanted Behavior

After Travis CI runs the unit tests successfully it should build the Docker image & push it to Docker hub.

If branch is master the image tag should be latest else it should be the same as the branch name (can look at TRAVIS_BRANCH envvar in Travis CI to get branch name being built)

Docker Hub should not build the images anymore as it ignores the unit tests failures.

Also the Docker Hub build tag should be removed from the README.md file

Actual Behavior

Docker hub builds the images while Travis CI runs the unit tests, each ignoring what the results of the other is.

@naorlivne
Copy link
Member Author

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant