Disallow impossible values for fail_under

[miketheman]

Since there's no way were likely to achieve greater than 100% code coverage,
disallow usage of any value above 100.

Resolves #743

Signed-off-by: Mike Fiedler [email protected]

[miketheman]

I tried to find a place to implement this other than a method that currently only returns a bool - but I didn't find anywhere that configs are validated, so I hope this is ok.

Very open to feedback here!

[nedbat]

Thanks! I took a quick look earlier, and I think I would have put the check in the same place you did.

I wouldn't make the message so flip :) Feel free to add yourself to the CONTRIBUTORS file. :)

[codecov-io]

Codecov Report

Merging #746 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
- Coverage   89.94%   89.92%   -0.02%     
==========================================
  Files          78       78              
  Lines       10799    10804       +5     
  Branches     1116     1117       +1     
==========================================
+ Hits         9713     9716       +3     
- Misses        959      960       +1     
- Partials      127      128       +1

Impacted Files	Coverage Δ
tests/test_results.py	100% <100%> (ø)	⬆️
coverage/results.py	95.91% <100%> (+0.05%)	⬆️
tests/test_summary.py	97.01% <0%> (-0.5%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce9194a...09da2fc. Read the comment docs.

[miketheman]

@nedbat I updated the error message to be a little less... opinionated. 😀

Codecov failure appears once I force-pushed the branch, it should probably re-report at some later time?

[nedbat]

Thanks!