Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phantomjs or replace with Electron | Object.defineProperty behavior #32

Closed
neetjn opened this issue Aug 24, 2017 · 1 comment
Closed

Comments

@neetjn
Copy link
Owner

neetjn commented Aug 24, 2017

Due to the changes in issue #30, we can no longer properly test events with options due to phantomjs's incorrect behavior of Object.defineProperty noted here ariya/phantomjs#14310.

We can either wait until a new version of phantomjs roles out and get's added to the npm package phantomjs-prebuilt, or look to moving to Electron or headless chrome.

@neetjn neetjn added this to the 2.0.0 milestone Aug 24, 2017
@neetjn neetjn self-assigned this Aug 24, 2017
@neetjn
Copy link
Owner Author

neetjn commented Sep 19, 2017

I've had to make a hot-fix due to an issue with the latest version of phantomjs not being able to process angular.js 1.5+. Our test cases now use chromium in headless mode.

@neetjn neetjn closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant