-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't display manga full screen in landscape mode when there is a notch #534
Comments
At this time this is expected. In most manga there is no benefit of drawing behind the notch as it cuts into the image. |
The notch is tiny and obstructs so little that I barely even notice it most of the time, so cutting off the entire column behind it is far less desirable since it makes the screen significantly smaller for no good reason. |
@CarlosEsco Can I work on this issue? |
Sure but it would probably actually require a change in https://github.com/Jays2Kings/subsampling-scale-image-view |
There are no plans to change this and J2K does not plan to either. It makes little sense to allow drawing behind the notch when it would end up covering the image. |
Don't really get it why not. Currently notches are minority. Front camera is also getting smaller by each generation. Fullscreen in vertical works correctly i.e. camera and top notification bar are ignored so the image fill the whole display. It looks really good and I don't think that someone will report this as an problem. Also if it were a option then everyone could decide if they want this or not. |
Device information
Steps to reproduce
Expected behavior
The entire screen should be covered with the manga page.
Actual behavior
A black column remains behind the camera notch.
Other details
The entire screen does properly get covered in portrait mode (while holding the phone in a vertical position), including the space next to the camera notch:
Tachiyomi doesn't have this problem:
The text was updated successfully, but these errors were encountered: