Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't display manga full screen in landscape mode when there is a notch #534

Closed
Bittah opened this issue Jul 3, 2021 · 6 comments
Closed
Labels
bug Something isn't working Working as designed

Comments

@Bittah
Copy link

Bittah commented Jul 3, 2021

Device information

  • Neko version: 2.5.1
  • Android phone & version: Samsung Galaxy A71, Android 11

Steps to reproduce

  1. Open a chapter of any manga
  2. Rotate phone to a horizontal angle to put it in landscape mode

Expected behavior

The entire screen should be covered with the manga page.

Actual behavior

A black column remains behind the camera notch.
Screenshot_20210704-005520_Neko

Other details

The entire screen does properly get covered in portrait mode (while holding the phone in a vertical position), including the space next to the camera notch:

Tachiyomi doesn't have this problem:
Screenshot_20210704-004036_Tachiyomi

@Bittah Bittah added the bug Something isn't working label Jul 3, 2021
@nonproto
Copy link
Collaborator

nonproto commented Jul 7, 2021

At this time this is expected. In most manga there is no benefit of drawing behind the notch as it cuts into the image.

@Bittah
Copy link
Author

Bittah commented Jul 7, 2021

The notch is tiny and obstructs so little that I barely even notice it most of the time, so cutting off the entire column behind it is far less desirable since it makes the screen significantly smaller for no good reason.

@nonproto nonproto changed the title [Bug] Neko doesn't display manga full screen in landscape mode Doesn't display manga full screen in landscape mode when there is a notch Jul 20, 2021
@chihung93
Copy link

@CarlosEsco Can I work on this issue?
I would like to set it full screen without a status bar in Landscape.

@nonproto
Copy link
Collaborator

nonproto commented Oct 6, 2021

Sure but it would probably actually require a change in https://github.com/Jays2Kings/subsampling-scale-image-view

@nonproto
Copy link
Collaborator

There are no plans to change this and J2K does not plan to either. It makes little sense to allow drawing behind the notch when it would end up covering the image.

@MMariusch
Copy link

Don't really get it why not. Currently notches are minority. Front camera is also getting smaller by each generation. Fullscreen in vertical works correctly i.e. camera and top notification bar are ignored so the image fill the whole display. It looks really good and I don't think that someone will report this as an problem.

Also if it were a option then everyone could decide if they want this or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Working as designed
Projects
None yet
Development

No branches or pull requests

4 participants