Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steps.<step id>.outputs fails when step referenced has dash (-) in name (0.2.8) #255

Closed
slotted-fork opened this issue May 23, 2020 · 1 comment
Labels
meta/duplicate This issue or pull request already exists

Comments

@slotted-fork
Copy link

Hey there,

Great tool.

Found a little snag with a workaround:

When using dash in the step-id the output from this step cannot be accessed in a later step.
This seems to work in GitHub

Changing the dash to an underscore resolves the issue.

act version 0.2.8

DarwinMacBook-Air.local 19.4.0 Darwin Kernel Version 19.4.0: Wed Mar 4 22:28:40 PST 2020; root:xnu-6153.101.6~15/RELEASE_X86_64 x86_64

[Docker/buggy] 🚀  Start image=nektos/act-environments-ubuntu:18.04
[Docker/buggy]   🐳  docker run image=nektos/act-environments-ubuntu:18.04 entrypoint=["/usr/bin/tail" "-f" "/dev/null"] cmd=[]
[Docker/buggy] ⭐  Run Login to Amazon ECR
[Docker/buggy]   ☁  git clone 'https://github.com/aws-actions/amazon-ecr-login' # ref=v1
[Docker/buggy]   🐳  docker cp src=/Users/svenhuster/.cache/act/aws-actions-amazon-ecr-login@v1 dst=/actions/
[Docker/buggy]   ⚙  ::set-output:: registry=OBFUSCATED.dkr.ecr.eu-west-2.amazonaws.com
[Docker/buggy]   ✅  Success - Login to Amazon ECR
[Docker/buggy] ⭐  Run Logout of Amazon ECR
ERRO[0002] Unable to interpolate string 'docker logout ${{ steps.login-ecr.outputs.registry }}' - [ReferenceError: 'ecr' is not defined]
| Not logged in to https://index.docker.io/v1/
[Docker/buggy]   ✅  Success - Logout of Amazon ECR
%
%
% act -P ubuntu-latest=nektos/act-environments-ubuntu:18.04 --secret-file .secrets-act -j good
[Docker/good] 🚀  Start image=nektos/act-environments-ubuntu:18.04
[Docker/good]   🐳  docker run image=nektos/act-environments-ubuntu:18.04 entrypoint=["/usr/bin/tail" "-f" "/dev/null"] cmd=[]
[Docker/good] ⭐  Run Login to Amazon ECR
[Docker/good]   ☁  git clone 'https://github.com/aws-actions/amazon-ecr-login' # ref=v1
[Docker/good]   🐳  docker cp src=/Users/svenhuster/.cache/act/aws-actions-amazon-ecr-login@v1 dst=/actions/
[Docker/good]   ⚙  ::set-output:: registry=OBFUSCATED.dkr.ecr.eu-west-2.amazonaws.com
[Docker/good]   ✅  Success - Login to Amazon ECR
[Docker/good] ⭐  Run Logout of Amazon ECR
| Removing login credentials for OBFUSCATED.dkr.ecr.eu-west-2.amazonaws.com
[Docker/good]   ✅  Success - Logout of Amazon ECR
%```


[buggy.txt](https://github.com/nektos/act/files/4671429/buggy.txt)
[good.txt](https://github.com/nektos/act/files/4671430/good.txt)

@cplee
Copy link
Contributor

cplee commented May 26, 2020

duplicates #104

@cplee cplee closed this as completed May 26, 2020
@cplee cplee added the meta/duplicate This issue or pull request already exists label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants