Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish/Cleanup types to be added to @DefinitelyTyped #419

Closed
danwbyrne opened this issue Aug 23, 2018 · 1 comment
Closed

Finish/Cleanup types to be added to @DefinitelyTyped #419

danwbyrne opened this issue Aug 23, 2018 · 1 comment
Assignees
@danwbyrne
Labels
area/client Categorize issue or PR as client (@neo-one/client) related kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon.

Comments

@danwbyrne
Copy link
Contributor

Types need to get moved around and then commited to @DefinitelyTyped so that they are can be installed with yarn install @types/neo-one. More to come.
@danwbyrne danwbyrne self-assigned this Aug 23, 2018
@danwbyrne danwbyrne added [zube]: Ready area/client Categorize issue or PR as client (@neo-one/client) related kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon. and removed [zube]: Ready labels Aug 23, 2018
@danwbyrne
Copy link
Contributor Author

danwbyrne commented Aug 24, 2018 •
edited
Loading

for the types
each directory in @neo-one/types
corresponds to a package
that needs to be added to DefinitelyTyped
i.e. installable by @types/
https://github.com/DefinitelyTyped/DefinitelyTyped#create-a-new-package
has instructions on adding new packages

@danwbyrne danwbyrne mentioned this issue Aug 24, 2018
Closed
This was referenced Sep 14, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danwbyrne danwbyrne

Labels
area/client Categorize issue or PR as client (@neo-one/client) related kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danwbyrne