Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: RoutingCommandController injects Router class instead of Interface #2948

Closed
1 task done
sorenmalling opened this issue Dec 30, 2022 · 0 comments · Fixed by #2970
Closed
1 task done

BUG: RoutingCommandController injects Router class instead of Interface #2948

sorenmalling opened this issue Dec 30, 2022 · 0 comments · Fixed by #2970

Comments

@sorenmalling
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The RoutingCommandController injects the default Router implementation. This causes a implementation, implements RouterInterface and configures it in Objects.yaml does not affect the output of the RoutingCommandController commands.

For example, overiding the default way of the route to gather routes to match, it not displated in the CLI as expected

Expected Behavior

The CLI tool routing:list should inject the interface and let the Objects.yaml take care of confiure the implementation.

Steps To Reproduce

No response

Environment

- Flow: All supported versions
- PHP:

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants