Skip to content
This repository has been archived by the owner on Aug 8, 2018. It is now read-only.

Replace external deps with homebrew formulae #198

Closed
3 tasks
equal-l2 opened this issue Nov 26, 2016 · 8 comments
Closed
3 tasks

Replace external deps with homebrew formulae #198

equal-l2 opened this issue Nov 26, 2016 · 8 comments

Comments

@equal-l2
Copy link
Contributor

equal-l2 commented Nov 26, 2016

Current external deps and why can't replace with homebrew formula now

  • luv - No formula yet
  • luajit - Homebrew luajit can't build neovim-bundled luarocks
  • luarocks - Homebrew luajit doesn't bundle luarocks, and luarocks formula doesn't exist
@justinmk
Copy link
Member

luajit can't build neovim-bundled luarocks

We can remove luarocks dep.

@equal-l2
Copy link
Contributor Author

equal-l2 commented Nov 26, 2016

@justinmk
I'm afraid it's not true.
If you remove luarocks, neovim install script cannot find lua, complaining
The 'lpeg' lua package is required for building Neovim.

@justinmk
Copy link
Member

Ah, right.

@javian
Copy link
Contributor

javian commented Nov 28, 2016

luarocks exists in the homebrew boneyard and it was re/moved here Homebrew/legacy-homebrew#37842 so it looks like any project that uses need to bundle it in the way its done now.

@equal-l2
Copy link
Contributor Author

equal-l2 commented Dec 1, 2016

Building bundled luarocks with homebrew luajit needs a patch so that configure can find luajit's lua.h correctly.

In detail, we need pass --with-lua-include=`brew --prefix luajit`/include/luajit-2.0 to luarocks' configure.

@equal-l2
Copy link
Contributor Author

equal-l2 commented Dec 1, 2016

Maybe we should go with current method with these 3 deps, instead of making difficult workarounds.

Homebrew seems not to work well with luajit.

@justinmk
Copy link
Member

justinmk commented Dec 1, 2016

@equal-l2 Agreed. At some point we will ship lua and the few lua-based dependencies "statically" as part of nvim core--similar to how the VimL runtime files are shipped. Then these homebrew-visible dependencies won't be needed. Update: in neovim/neovim#4411 we don't "inline" lua, we still require lua or luajit as dependencies.

@equal-l2
Copy link
Contributor Author

equal-l2 commented Dec 1, 2016

Then we will wait until the time comes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants