WIP: Can not combine URL params and body #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
changed the title
|
@fortmarek Whats the state of this PR? I haven't looked at it until now because it had |
|
hi @pietbrauer, I don't really have time to finish this PR. If anyone else needs this, they are free to take this to the finish line 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
To resolve this issue I need a way to define URL query parameters and also be able to add a body - as per github API documentation.
This does not seem to be possible at the moment (or I could not find a way to do this).
Even more weirdly, if I define some
paramsand setHTTPEncodingto.url, theparamsare still encoded intoJSONinpostfunction which does not seem to be right.Currently, I have tried to make minimal changes to the codebase while achieving what I want, but for a proper solution there'd probably have to be breaking changes (as of now the change is only additive).
Let me know if you feel like this is a way to go or if I should take a completely different path 🙂