-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat package failed transactions #684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyr
force-pushed
the
feat-package-failed-txs
branch
2 times, most recently
from
May 10, 2022 01:38
64428fc
to
21e16a3
Compare
jjyr
force-pushed
the
feat-package-failed-txs
branch
from
May 10, 2022 06:02
21e16a3
to
8c312b7
Compare
blckngm
reviewed
May 11, 2022
blckngm
approved these changes
May 12, 2022
zeroqn
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of only package success transactions caused some problems:
the nonce becomes inconsistent once user send a failed transaction.
So this PR introduce a backward compatible way to fix this. When a transaction is failed(return a non-zero exit code), the written state of the transaction is reverted, the sender's nonce is increased by 1, and the transaction fee is paid to block-producer. For
PolyjuiceTx
thegas_used * gas_price
amount of CKB is charged. For other transaction, theargs.fee
is charged.